Oracle purges dropped temp tables #17506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
reviewed
May 15, 2023
| @@ -296,6 +297,19 @@ public void dropSchema(ConnectorSession session, String schemaName) | |||
| throw new TrinoException(NOT_SUPPORTED, "This connector does not support dropping schemas"); | |||
| } | |||
|
|
|||
| @Override | |||
| protected void dropTable(ConnectorSession session, RemoteTableName remoteTableName) | |||
There was a problem hiding this comment.
I do not matching by name. It looks like you could pass the boolean temporaryTable flag explicitly via parameter.
losipiuk
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is in response to #16277
The issue appears to be due to Oracle's recycling bin, which holds onto dropped tables for a period of time.
This has caused issues in our BaseFailureRecoveryTest, which expects there to be no remaining temporary tables after each test case. The solution implemented here is to
PURGEtrino's temporary tables (tmp_trino_*), which bypasses the recycling bin, dropping the table immediately.We could
PURGEall dropped tables, but this code path is also used when an end user explicitly drops one of their own tables, so that may be unexpected behavior.Additional context and related issues
Release notes
(X) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: